jillesvangurp / stellar-kotlin-client

Kotlin wrapper for the Stellar java sdk with some added kotlin convenience
MIT License
14 stars 1 forks source link

SEP-10 v3.1 Changes (from the SDF) #15

Open JakeUrban opened 3 years ago

JakeUrban commented 3 years ago

SEP-10 3.1 Support

TL;DR

Implement the changes described the SEP-10 3.1 commit.

This likely involves adding an optional argument to the SEP-10 utility functions for adding an additional Manage Data operation containing the domain of the SEP-10 server (web_auth_domain).

Background & Description

Thank you for implementing SEP-10 v3.0, which reintroduced verification of the home domain of the service requiring SEP-10 authentication, ensuring that signed challenges cannot be used for any other service.

SEP-10 v3.1 adds an optional Manage Data operation that includes the home domain of the service issuing SEP-10 challenges. This allows clients and servers to verify the issuer of the challenge.

JakeUrban commented 3 years ago

https://github.com/stellar/stellar-protocol/pull/767