jim-easterbrook / Photini

An easy to use digital photograph metadata (Exif, IPTC, XMP) editing application.
https://photini.readthedocs.io/
GNU General Public License v3.0
163 stars 24 forks source link

Geotagging: enhanced marker #253

Closed regexgit closed 1 month ago

regexgit commented 2 months ago

I just have one very minor improvement to suggest:

After a birdwatching trip, I geotagged several birds in the same place (multi-select then drag&drop onto the map). Then I noticed a mistake, the last one had been photographed at a different location: I selected my photo, moved the red marker and ... shit, all the other photos were also moved to the new location.

Of course this isn't a bug, it's a feature (no irony intended...): the photos belong to the same location group, so it's normal for them to be moved to the new location. I should have deleted the coordinates of the last one to detach it from the group.

What's more, I was warned: when I click on the marker all the photos in the group are selected in the image selector.

But I don't think that's enough, I often have to make location changes and I'd really appreciate it if the marker had a little extra sign (a ‘+’ sign for example) to remind me that several photos are linked to this marker.

jim-easterbrook commented 2 months ago

That should be possible.

What you should have done is to select the image(s) with the wrong location, then drag them from the image selector area to the map.

regexgit commented 2 months ago

Easier of course, I'm still lacking experience but I hope to improve :smiley:

jim-easterbrook commented 2 months ago

There's often more than one way to do something. Dragging from the image selector is particularly useful when you want to move them to another town / city / country / continent.

jim-easterbrook commented 2 months ago

I've been doing some experimenting with adding text to markers (e.g. a number to show how many images share that position). Each map provider is different, but several use an HTML element for the marker. So instead of using a simple img element you can use a div containing the marker image and some text. CSS is used to position the text over the image. Doing all this moves the marker, so the offsets need adjusting. It's all rather messy and the end result doesn't look very good either.

It also doesn't solve your problem - what you need is an indication that some of the marker's images are selected and some not. I might try a striped grey/red marker to show that.

regexgit commented 2 months ago

I didn't realize that the display depended on the card provider. If it's complicated forget it, it's a useful improvement but not essential.

jim-easterbrook commented 2 months ago

I'm not sure striped markers are going to do the job. Screenshot_20240830_141134

regexgit commented 2 months ago

Ok for the striped markers, but I don't understand your example: the marker is associated with a single image, so it should be (normal) solid red, right?

jim-easterbrook commented 2 months ago

No, the marker is associated with a single location, which several images might share. If all images at that location are selected it would be all red. If none of the images at that location are selected it would be all grey.

(The image is mocked up - I haven't yet made the changes needed to the map software.)

jim-easterbrook commented 2 months ago

You wanted to highlight that several photos are linked to one marker. For me that's a normal situation, so I would highlight that several photos are linked to one marker and not all of them are selected. (Which is the case with your bird photos after you'd selected the one photo that didn't belong at that location.)

regexgit commented 2 months ago

That's right, I hadn't thought of it that way, but it's just what I needed and it's a more elegant solution.

jim-easterbrook commented 2 months ago

I think the striped marker is not visible enough - the stripes hide it like a zebra's stripes hide a zebra. A simple half & half marker might be better. Screenshot_20240831_102333

jim-easterbrook commented 2 months ago

I ought to consider the effect on people with the common red-green colour blindness as well. This is a more general problem with Photini, so I've opened a new bug #263.

jim-easterbrook commented 1 month ago

I've been experimenting with various marker designs, and considering other ways to help with your problem. Nothing I can think of is satisfactory to me.

I hope that the more prominent colouring of selected image thumbnails might alert you when you click on a marker before dragging it.

I'll keep this issue open, rather than marking it "won't fix", but I don't plan to do it for the release I want to do in the next week or two.

regexgit commented 1 month ago

I've just come back from a trip and geotagged a lot of photos: I've got used to moving the thumbnails instead of the markers so this problem doesn't bother me any more.

However, I've found another problem: I opened a new ticket