search

jim-easterbrook / Photini

An easy to use digital photograph metadata (Exif, IPTC, XMP) editing application.
https://photini.readthedocs.io/
GNU General Public License v3.0
157 stars 24 forks source link

added PHOTINI_CONFIG environt variable #34

Closed ghost closed 6 years ago

ghost commented 6 years ago

Adds a configuration variable (PHOTINI_CONFIG) as an alternative to determine the location of the configuration. If the configuration variable is not set (in the os), the behavior does not change from present.

Motivation: I locate the configuration in an area that is backed up to a cloud service (Dropbox) and also shared between several computers I use Photini with.

jim-easterbrook commented 6 years ago

I have a few questions. Why have you added main.py? What is readme.adoc for? gpxmap.py appears to be the same as openstreetmap.py, so why not use that as a base class? I'd prefer it if you submitted separate pull requests for the unrelated changes you are proposing.

ghost commented 6 years ago

First, many thanks for a great tool. Second - sorry for the mess. I meant to only submit a PR for the environment variable and am not sure why the other stuff was included (when I submitted the PR it was not, as I had not even committed the other changes yet).

I'll have to learn about PRs to resubmit this correctly. Until then - should we just delete (close?) this PR?

jim-easterbrook commented 6 years ago

Yup, I've been caught the same way. GitHub assumes that any further submits you make to your repos are intended as additions to the pull request. I think the best way is to create a new branch (e.g. "configenv"), make the minimal changes there and submit a pull request from that branch, then continue your experiments on a different branch. That said, I like the idea of having the ability to store your config elsewhere and it's simple to do, so I may just go ahead and do it anyway.

ghost commented 6 years ago

Let's do it this way, many thanks. Only a couple of lines of code. I'll figure out how to use branches if I have something else to contribute.

jim-easterbrook commented 6 years ago

Commit 747eb43 adds this feature.