search

jim-easterbrook / Photini

An easy to use digital photograph metadata (Exif, IPTC, XMP) editing application.
https://photini.readthedocs.io/
GNU General Public License v3.0
156 stars 24 forks source link

Application/start menu entries not being created when installing Photini #56

Closed jim-easterbrook closed 3 years ago

jim-easterbrook commented 3 years ago

Recent versions of pip do not behave as I expected when writing Photini's installation setup.py script. It should run a "post install script" to install the application/start menu entries, but the authors of pip are against running code at install time. (Big discussion of the whys and wherefores here: https://github.com/pypa/packaging-problems/issues/64.)

It seems that I'll have to change Photini's installation instructions to include running a script or command after installation, although this will make it easier for anyone who doesn't want an application/start menu entry not to have one.

The Windows installer will probably be able to run the script directly, after using pip to install the Photini package, so the sort of users who can't run a command line script might not be affected.

jim-easterbrook commented 3 years ago

Commit b0aaa26 is a first step on this path.

jim-easterbrook commented 3 years ago

Release 2020.12.1 fixes the problem, and provides a post install command to install (or remove) menu entries on Windows and Linux.