search

jim-easterbrook / pywws

Python software for USB Wireless WeatherStations
https://pywws.readthedocs.io/
GNU General Public License v2.0
204 stars 63 forks source link

adding mqtt publishing of data #16

Closed thompsonson closed 9 years ago

thompsonson commented 10 years ago

As discussed on https://groups.google.com/forum/#!topic/pywws/_pLaip_XR64

rk295 commented 9 years ago

Hi, is there anything in particular preventing this PR from being merged? I ask because I was about to implement this functionality when I saw this PR, and helping this along the path to master strikes me as less work than me writing this feature from scratch :)

r.

thompsonson commented 9 years ago

I've been running it on a RPi now for a few months (in line with the commits) - not seen any issues publishing to the MQTT broker I'm running in that time.

jim-easterbrook commented 9 years ago

I'd forgotten about this. If I remember correctly I was a bit worried that it requires users to modify the service .ini file to configure things. This will be a problem for pywws users who install with pip as they don't have way access to the source files. If it can be made more like the other services (from a user's point of view) that would be good.

thompsonson commented 9 years ago

I think that came about from crossed wires whilst I was working on it. Now the only ini needed to edit is the weather.ini. I have included documentation on what values, in the weather.ini, are required as part of the pull request.

jim-easterbrook commented 9 years ago

Ah, I see. I spotted the documentation after I'd made the above comment, and before I edited the comment. (-: There are some conflicts to resolve before the pull request can be merged. I'll have a go later today.

jim-easterbrook commented 9 years ago

I managed to resolve the conflicts but it seems to have lost all the contributor history. (I'm still struggling to master git.) Sorry about that, Matt.

rk295 commented 9 years ago

Thanks Jim! Christmas hacking for me sorted :+1:

thompsonson commented 9 years ago

No worries, my first contribution to an established open source project so I’m glad to be adding a small bit back. :)

Hope it’s useful to you Robin.

Season greetings!

Matt

On 22 Dec 2014, at 11:57, Jim Easterbrook notifications@github.com wrote:

I managed to resolve the conflicts but it seems to have lost all the contributor history. (I'm still struggling to master git.) Sorry about that, Matt.

— Reply to this email directly or view it on GitHub https://github.com/jim-easterbrook/pywws/pull/16#issuecomment-67829507.