search

jim-easterbrook / pywws

Python software for USB Wireless WeatherStations
https://pywws.readthedocs.io/
GNU General Public License v2.0
204 stars 62 forks source link

MQTT and templating etc. #24

Closed mortenf closed 9 years ago

mortenf commented 9 years ago

I have added support for template "override" for services, which I needed for MQTT - that now has a shorter interval. The modified MQTT-template thus isn't strictly necessary, but it now adheres to JSON syntax (double quotes). Also added is a DMI template without a solar value.

jim-easterbrook commented 9 years ago

Your changes to mqtt_template_1080.txt are not backwards compatible, as you've changed the names of many items. Also I think it will fail when data items are missing, for example when contact is lost with the outside sensors.

I know nothing about DMI, but shouldn't your template report no solar value, rather than an untrue value of zero?

mortenf commented 9 years ago

Agree on the mqtt_template_1080.txt points: I'll revert to just changing the syntax, and add my template as an example instad.

The reason for using raw in the new template is to make it possible to get to the actual rain observation (change) - I'll be happy for suggestions on other methods.

Regarding DMI I was in contact with them to make my own system work - they have a very simple and rigid parser, that won't accept anything if everything isn't as expected, including a solar value.

I'll refork when we agree on the changes.

jim-easterbrook commented 9 years ago

Thanks. When you refork can I also suggest you set the copyright on the files you add or change to "pywws contributors", as I've been doing to other files. This is the new pywws "house style", as many files have several contributors. Git history will show who contributed what.