search

jima80525 / mp3splitter

Splits Audiobook mp3 files into chapters
MIT License
22 stars 7 forks source link

Issue 3/chapter markers xml #7

Closed taylorlowery closed 2 years ago

taylorlowery commented 2 years ago

Running the splitter on a file now creates a filename.xml file in the same folder. If the xml file is copied with the name filename_fixed.xml and the existing file/split files deleted, it will be recreated with the chapter titles in the filename_fixed.xml file.

jima80525 commented 2 years ago

Taylor - I haven't had a chance to look over the changes in any detail, but they look pretty cool - definitely much cleaner than what I had there (in my defense, I never imagined anyone would ever look at this code :) ) I'm certainly open to taking PRs and I hope my slow response time wasn't an issue.

taylorlowery commented 2 years ago

Hey Jim! No judgement at all about the state of your code -- for starters, it's plenty clean, and it's a great foundation I'm using to help a friend of mine with a personal project(cleaning up a huge library of ebooks that has terrible metadata). Thank you very much for 1) building it in the first place, and 2) being gracious about my accidental PRs so far! Github's default behavior makes it really easy for me to accidentally PR to your repo instead of my fork. Your response time was no issue at all! My fork currently has some code that is really specific to my project, but I was already planning on creating another branch to submit some of the changes I've made that will make it easy for others to use your mp3 splitter out of the box (if that's not overstepping!). Thank you again, and talk to you soon!

On Sat, Aug 13, 2022 at 12:28 PM Jim Anderson @.***> wrote:

Taylor - I haven't had a chance to look over the changes in any detail, but they look pretty cool - definitely much cleaner than what I had there (in my defense, I never imagined anyone would ever look at this code :) ) I'm certainly open to taking PRs and I hope my slow response time wasn't an issue.

— Reply to this email directly, view it on GitHub https://github.com/jima80525/mp3splitter/pull/7#issuecomment-1214211185, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM235G6LDBKSR4NXFXVX2TVY7ZOTANCNFSM56NNTA7Q . You are receiving this because you modified the open/close state.Message ID: @.***>