search

jimbaker / tagstr

This repo contains an issue tracker, examples, and early work related to PEP 999: Tag Strings
51 stars 6 forks source link

Post PyCon PEP cleanup #43

Closed pauleveritt closed 3 months ago

pauleveritt commented 3 months ago

More focus on protocols, remove extraneous sections.

pauleveritt commented 3 months ago

@lysnikolaou I worked with @jimbaker the last week to wrap up the PEP. It's in good shape for review. Jim's cleanup really helped readability.

It tracks some changes in main (3.14) for how Protocols can be used in structural pattern matching, so the examples won't run on the 3.12-based tag string branch.

Do you mind giving it a look?

rmorshea commented 3 months ago

Does anyone know if peps.python.org supports admonitions? (e.g. .. note::). I kind of suspect it does since I've seen tables and other more complicated directives used in PEPs. If so, there are a few places that might benefit from that extra formatting flourish.

lysnikolaou commented 3 months ago

@lysnikolaou I worked with @jimbaker the last week to wrap up the PEP. It's in good shape for review. Jim's cleanup really helped readability.

It tracks some changes in main (3.14) for how Protocols can be used in structural pattern matching, so the examples won't run on the 3.12-based tag string branch.

Do you mind giving it a look?

Thanks for the ping @pauleveritt! I'll take a look later today.

Does anyone know if peps.python.org supports admonitions?

Yes, it does. There's a list of what the CPython documentation supports on this devguide page and I'm pretty sure that peps.python.org support all of that as well.

pauleveritt commented 3 months ago

I had a brief pass over the changes, which look good to me! Let's merge this, so that I can go through the PEP as a whole one more time and review it more deeply then.

@lysnikolaou Think you have time to review more deeply before we announce to broader group?

lysnikolaou commented 3 months ago

Sure! I'll have a look and post any comments I have later today. Not sure what the best place to do that would be though, I'll probably just open a new PR with my suggestions if I have any.