jimblackler / jsonschemafriend

A JSON Schema loader and validator, delivered as a Java library.
Apache License 2.0
49 stars 23 forks source link

Closing stream after using it to avoid resource leaks #22

Closed ghost closed 2 years ago

ghost commented 2 years ago

A stream is being opened without closing it, causing resource leaks

jimblackler commented 2 years ago

Thank you.

ghost commented 2 years ago

Thank you.

You are welcome. Could you upload a release with the fix?

jimblackler commented 2 years ago

I made 0.11.4. Let me know if there are any issues.

ghost commented 2 years ago

Thank you! Great library, keep up the good work ;)

ghost commented 2 years ago

It seems that there was a problem with the release in jitpack :o https://jitpack.io/#net.jimblackler/jsonschemafriend

jimblackler commented 1 year ago

This has happened before. There's no way I know of to make it rebuild without making a new version. I've logged https://github.com/jitpack/jitpack.io/issues/5232 so hopefully the JitPack folks can unstick it.

On Mon, 19 Sept 2022 at 07:05, Gustavo @.***> wrote:

It seems that there was a problem with the release in jitpack :o https://jitpack.io/#net.jimblackler/jsonschemafriend

— Reply to this email directly, view it on GitHub https://github.com/jimblackler/jsonschemafriend/pull/22#issuecomment-1250603071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFH6F3P6YMWZDKON54OK63V677CRANCNFSM6AAAAAAQOWCBZI . You are receiving this because you modified the open/close state.Message ID: @.***>

ghost commented 1 year ago

Thank you

jimblackler commented 1 year ago

I managed to force a rebuild and it looks like it worked.

On Mon, 19 Sept 2022 at 18:23, Gustavo @.***> wrote:

Thank you

— Reply to this email directly, view it on GitHub https://github.com/jimblackler/jsonschemafriend/pull/22#issuecomment-1251319700, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFH6FYBJX54WCYK4PADW23V7COSHANCNFSM6AAAAAAQOWCBZI . You are receiving this because you modified the open/close state.Message ID: @.***>

ghost commented 1 year ago

Thank you!!

ghost commented 1 year ago

It seems to be broken again :( https://jitpack.io/#net.jimblackler/jsonschemafriend