Closed simonlindholm closed 11 years ago
Ideally, a Debugger with no hooks certainly wouldn't impose any overhead.
Debugger.prototype.makeDebuggeeValueFromGlobal seems like a good idea. Would you like to give it a shot?
I don't have have the Firefox source code checked out, but I guess something like this should do it: https://gist.github.com/simonlindholm/5627711
Can you take it from there?
Or should I open a bug?
If you could file a bug in Bugzilla for this, that would help me and Honza keep track of it.
I can't work on this immediately, but if the bug is filed, then Honza can shepherd it forward.
Thanks for the proposed patch. The implementation is a little odd, but the API looks fine.
On Wed, Jun 5, 2013 at 3:07 PM, Simon Lindholm notifications@github.comwrote:
Or should I open a bug?
— Reply to this email directly or view it on GitHubhttps://github.com/jimblandy/DebuggerDocs/issues/7#issuecomment-19012347 .
Please CC Honza and me on the bug.
Okay, thanks. Filed bug 880177.
jimb: ping!
Firebug wants to get Debugger.Objects for globals without having to go into debug mode, so that it can expose functions environments to content (wiki link), and use
evalInGlobalWithBindings
for command line evaluation, neither of which (seemingly) requires the global to be held as a debuggee. I presume that the Web Console also wants to avoid the perf impact of the latter.There doesn't seem to be a technical reason for not having such an API, because as far as I can tell e.g.
has the same effect (though it's a hack and also triggers debug mode in some unrelated compartment).
Could a
Debugger.prototype.makeUnwrappedDebuggeeValue
orDebugger.prototype.makeDebuggeeValueFromGlobal
or something be added?Or is it against the API design, with the aim instead being to fix debugger performance (e.g. bug 783428, bug 809563)?