search

jimbo8098 / windows-docker-role

An Ansible Role to Install Docker on Windows
https://galaxy.ansible.com/jimbo8098/windows-docker-role
0 stars 3 forks source link

Conditional check within Install Docker Task is Improvable #2

Open jimbo8098 opened 3 years ago

jimbo8098 commented 3 years ago

Currently, the task is structured in the code blocks below:

https://github.com/jimbo8098/windows-docker-role/blob/10770bbb5ea32377ad55955b8535034be0fc12a5/tasks/main.yml#L51-L58

https://github.com/jimbo8098/windows-docker-role/blob/10770bbb5ea32377ad55955b8535034be0fc12a5/tasks/main.yml#L60-L68

This should be converted to ensure that docker.version exists prior to the equality check otherwise it will fail if you diverge some of the variables within the docker dict.