jimboca / udi-poly-kasa

UDI ISY Polyglot NodeServer for TP-Link Kasa
MIT License
2 stars 4 forks source link

Some devices are not added to ISY because of illegal characters in Kasa device name #25

Closed jimmckain closed 2 years ago

jimmckain commented 2 years ago

A device with a character that the ISY does not support prevents them from showing up in the ISY.

The code should filter any invalid characters from the device name (like [ ] ( ) < > \ / * ! & ? ; " ') before adding the Node to the ISY.

Of course, you can rename the nodes in the ISY as you like after they show up. But they have to show up first.

In example, if you name a device using the Kasa app to HDTV/Audio it will not show up in the ISY.

jimboca commented 2 years ago

Surprised I missed that, thanks for pointing it out. Will fix in next PG3 release: https://github.com/UniversalDevicesInc-PG3/udi-poly-kasa/issues/4 unless it's really needed for PG2.

jimmckain commented 2 years ago

V3 should be fine, just documenting it.

Best Regards, Jim McKain Office 978 686 1700 x205 Mobile 978 815 3960 Skype Jim.McKain http://www.autoingest.com http://www.nltek.com/AvidWorkflows

On Tue, Feb 22, 2022 at 12:46 PM JimBoCA @.***> wrote:

Surprised I missed that, thanks for pointing it out. Will fix in next PG3 release: UniversalDevicesInc-PG3/udi-poly-kasa#4 https://github.com/UniversalDevicesInc-PG3/udi-poly-kasa/issues/4 unless it's really needed for PG2.

— Reply to this email directly, view it on GitHub https://github.com/jimboca/udi-poly-kasa/issues/25#issuecomment-1048053956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJI6T64NIVA53EJK5FUU2H3U4PDWHANCNFSM5PCBPFRQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

--

This message (including any attachments) is intended only for the use of the individual or entity to which it is addressed and may contain information that is non-public, proprietary, privileged, confidential, and exempt from disclosure under applicable law or may constitute as attorney work product. If you are not the intended recipient, you are hereby notified that any use, dissemination, distribution, or copying of this communication is strictly prohibited. If you have received this communication in error, notify us immediately by telephone and (i) destroy this message if a facsimile or (ii) delete this message immediately if this is an electronic communication.

jimboca commented 2 years ago

Thanks, will work on that soon

jimboca commented 2 years ago

Fixed in 3.0.10