Python 3 is coming - Githubissues

jimbraun / XCDF

XCDF: eXplicitly Compacted Data Format. See documentation at Read the Docs:

https://xcdf.readthedocs.io/en/latest/

Other

14 stars 8 forks source link

Python 3 is coming #87

Open colasri opened 5 years ago

colasri commented 5 years ago

The build fails when python 3 is present:

error: use of undeclared identifier 'PyString_FromString' error: use of undeclared identifier 'PyString_AsString' error: use of undeclared identifier 'PyString_AsString' ...

Options:

fix bindings with python 3
or at least still be able to compile the C++ library without python bindings

jimbraun commented 5 years ago

With Python 3, str literals are now unicode objects. The solution is probably to define fromStringLiteral and asStringLiteral methods that have #ifdef based on the presence of Python 3. If we're in a Python 3 environment, use PyUnicode_FromString and PyUnicode_AsString.

colasri commented 5 years ago

I don't know if @sybenzvi wants to take care of it, if not I'll put it on my todo list.

HealthyPear commented 1 year ago

@jimbraun I think we can close this issue now that #93 has been merged