search

jimbuck / pully

A simple CLI and library for downloading high quality YouTube videos!
https://www.npmjs.com/package/pully
MIT License
189 stars 19 forks source link

Adds keywords to package.json #23

Closed nfiles closed 7 years ago

nfiles commented 7 years ago

Resolves #19

Adds the specified keywords to the package.json. Let me know if I missed anything. I have not added keywords to a package before. :)

jimbuck commented 7 years ago

Nice, did you register for Hacktoberfest first?

Looks like the download of ffmpeg is failing on the build server!

nfiles commented 7 years ago

I did! :)

Huh, that's strange. I don't think flvtool2 exists in apt-get anymore. I'm running Ubuntu 14.04 (yikes, I should upgrade). It looks like the fluent-ffmpeg Travis CI build is failing as well: https://travis-ci.org/fluent-ffmpeg/node-fluent-ffmpeg/jobs/286271956

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.994% when pulling aafe83ee743b03d5f867013f251dbf19c376bb6a on nfiles:issue-19-keywords into 23640c77963f54cb2709bbcc16ad3d335dc182ca on JimmyBoh:master.

nfiles commented 7 years ago

I added a third-party repository for installing flvtool2, which seems to fix the CI build. :)

jimbuck commented 7 years ago

Awesome!