Don't allow adding removed characters as friends

[jeanke75]

Reproduce: Character select > Delete >Select a different character > Connect Sever Select > Select a world > Connect Press 'J' (open friends list) > Add > Type in removed characters name > Add

Result: The removed character is added to the friends list

Expected result: Don't allow adding removed characters, either by removing them completely or only allow adding online players to the friends list.

Side notes:

• Are all ties to a deleted character removed when deleted? Think guild entry, friends list etc
• Should characters be deleted straight away or be highlighted for deletion after x days so people can undo the action?

[jimdroberts]

Characters are not completely deleted in the database unless specified. Most data persists just incase the need to reinstate the character arises. There is a Deleted field that is available to check if a character has been deleted or not. This field is was not checked when adding a friend to the database.

CharacterService.GetByName has been modified with a third field to force check if the character has been deleted or not.