search

jimeh / build-emacs-for-macos

Somewhat hacky script to automate building of Emac.app on macOS.
484 stars 50 forks source link

The option was recently renamed to native-compilation #36

Closed tjsousa closed 3 years ago

tjsousa commented 3 years ago

Native compilation would not be detected when configuring without this change.

jimeh commented 3 years ago

Thanks for the submission, though this is already addressed by commit 581594da3cfbf1dd2fa28e91710b767e21ff75d2 in such a way that it can compile both old a new source trees by detecting which of the two flags is needed to enable native compilation.

The build-emacs-for-macos command accepts a git ref (branch, tag, or commit from the emacs-mirror/emacs repo), rather than configure options. It has its own set of options though which control certain aspects of how it compiles Emacs.

So I'm afraid I will need to reject this change, as it would actually yield an error cause the branch is stilled named feature/native-comp:

$ ./build-emacs-for-macos feature/native-compilation
ERROR: Failed to get commit info about: feature/native-compilation

Feel free to reply here or open a new issue if you've got any problems though :)

tjsousa commented 3 years ago

That makes sense. Thank you for the explanation, for some reason I wasn't able to compile with native compilation support by copying the latest git sha from https://github.com/jimeh/build-emacs-for-macos/issues/6#issue-683067223 and somehow was able to compile by changing the feature name (but it seems I was confusing the name of the argument with the branch name).

jimeh commented 3 years ago

Ah right, yes, the --git-sha option overrides the git ref lookup, making it just use the given git ref as a "name" for the final archive. I've been meaning to refactor that for a while as it's led to a decent bit of confusion.