search

jimeh / emacs-builds

Self-contained Emacs.app builds for macOS, with native-compilation support.
https://github.com/jimeh/emacs-builds/releases
355 stars 8 forks source link

Some source code files missing in the output build #40

Open shipmints opened 2 weeks ago

shipmints commented 2 weeks ago

e.g., nsterm.m isn't in Resources/src but the nsterm.h file does get propagated. Curious.

jimeh commented 2 weeks ago

Ah, yeah that's an oversight on my part. The sources embedding code only picks up *.c and *.h files from Emacs' src directory. Are there any other extensions aside from *.m that should be added to the list?

shipmints commented 2 weeks ago

All the ChangeLogs, the .dbxinit, .gdbinit files, the xbm bitmaps. Why not just blindly copy everything? I think that's what should be done, actually. If your build (I haven't looked) "shites where it sleeps" and speckles object files all over the src tree then either change the autoconf output dir to shite somewhere else or copy a pristine src tree separately?

jimeh commented 2 weeks ago

Fair point. Originally I included the source files just for the sake of M-x describe-function and similar for stuff defined in C to actually be able to link to and show the source. So I wasn't very concerned about files that wouldn't be needed for that.