search

jimeh / tmux-themepack

A pack of various Tmux themes.
1.65k stars 204 forks source link

Update to tmux 2.9 configuration #25

Closed marsam closed 5 years ago

marsam commented 5 years ago

From tmux releases notes https://github.com/tmux/tmux/blob/2.9/CHANGES

  • The individual -fg, -bg and -attr options have been removed; they were superseded by -style options in tmux 1.9.

Fixes https://github.com/jimeh/tmux-themepack/issues/24

jimeh commented 5 years ago

Thanks for this, it looks good aside for my comment about the flipped values.

This will annoyingly break compatibility with Tmux 1.8 though. I've got a fix for that in the works, but it'll take me a few more days. Considering the age of 1.8, I think its OK to break it for a few days in favor of supporting 2.9.

marsam commented 5 years ago

This will annoyingly break compatibility with Tmux 1.8 though

I think you could tag and branch off https://github.com/jimeh/tmux-themepack/commit/126150da5e89b262fec94dd7b3d8bcd0966646a9, and add a reference in the readme for users with tmux<2.9

jrobichaud commented 5 years ago

This fixes the issues I had with tmux 2.9. 👌