search

jimevins / glabels-qt

gLabels Label Designer (Qt/C++)
http://glabels.org
GNU General Public License v3.0
328 stars 90 forks source link

Native KDE look and feel #30

Open samdolt opened 6 years ago

samdolt commented 6 years ago

Currently, GLabel doesn't feel like "native" on KDE.

By using some KDE Framework Libraries, GLabels could get some feature for free, and a native look and feel on KDE:

Configure shortcuts Configure toolbars

If it's ok on your side, I could work on this and make a pull request

mariobl commented 6 years ago

If it doesn't affect the behavior in Qt-only environments, it would be a good idea.

jimevins commented 6 years ago

I am hesitant about this. Glabels-qt is a cross platform/desktop Qt application -- not a KDE application -- I have just divorced it from its previous GNOME dependencies -- I don't really want to now add KDE dependencies. I would only be interested if this could be an optional dependency requiring explicit opt-in at build time. It would also need to be architected to avoid ifdef-hell. The drawback to this is that I would then need to maintain testing of both configurations.

You mention the KDE icon themes. To me, worse than not appearing native to the desktop, would be to have a mixture of native and non-native icons within the same app -- this has been an issue with the previous GTK versions. gLabels has quite a few icons that are unique to gLabels and thus would not be themed. I purposely created a complete "flat" icon set for gLabels, so that it would not mix desktop themed icons with gLabels unique icons. I would prefer to build a selection of complete internal icon themes.

mariobl commented 6 years ago

I purposely created a complete "flat" icon set for gLabels, so that it would not mix desktop themed icons with gLabels unique icons. I would prefer to build a selection of complete internal icon themes.

If the mentioned gLabels unique icons would be really unique (don't know whether the current names appear anywhere as stock icons), it would become quite easy for designers to add them to their theme packs. Well, it could happen that designers don't create new icons and just link to existing ones. Anyway, my proposals:

label-orientation-horiz.svg → glabels-label-orientation-horiz.svg label-orientation-vert.svg → glabels-label-orientation-vert.svg print.svg → glabels-print.svg select-product.svg → glabels-select-product.svg