jimhester / knitrBootstrap

A framework to create bootstrap styled HTML reports from knitr Rmarkdown.
Other
274 stars 61 forks source link

Add support for rendering ggvis output #165

Open khughitt opened 9 years ago

khughitt commented 9 years ago

ggvis plots can now be rendered to the vanilla html_document rmarkdown class, e.g.

https://github.com/rstudio/ggvis/blob/master/vignettes/interactivity.Rmd

Currently, the rendering fails, however, in knitrBootstrap.

The issue appears to be related to some inline scripts that are required not being inserted properly; comparing the output from html_document and knitrBootstrap::bootstrap_document.

jimhester commented 9 years ago

Did you try this with https://github.com/jimhester/knitrBootstrap/pull/68, it should work with that, at least it did when I made http://jimhester.github.io/ggplot2ToGgvis/. If it is failing with that I will have look into it. Now that rmarkdown is using Bootstrap 3 I can simplify some things on the knitrBootstrap side, which should iron out more of these issues.