search

jimhester / knitrBootstrap

A framework to create bootstrap styled HTML reports from knitr Rmarkdown.
Other
274 stars 61 forks source link

Allow knitrBootstrap to be used as a vignette engine #169

Open dtenenba opened 9 years ago

dtenenba commented 9 years ago

Currently if a package vignette wants to use knitrBootstrap it has to have a Makefile. However, if knitrBootstrap registered a vignette engine, then the package author would just have to specify VignetteEngine: knitrBootstrap in DESCRIPTION and %\VignetteEngine{knitrBootstrap::knit_bootstrap} in the vignette. See the discussion on non-Sweave vignettes in Writing R-extensions, and the help for ?tools::vignetteEngine.

jimhester commented 9 years ago

This is true. Pull request #68 should be able to do this using the rmarkdown vignetteEngine already, but it has some other unresolved issues as well. Unfortunately I have been working on other side-projects so knitrBootstrap has been sadly neglected.

Rmarkdown now has ~95% of the features of knitrBootstrap, so I am not sure how much further it is worth taking this project, it seems mostly redundant to me at this point.

jimhester commented 9 years ago

That being said, registering a vignetteEngine shouldn't be too much work, so it can probably be done.

dtenenba commented 9 years ago

Thanks for the feedback. I am dealing with a package that is using knitrBootstrap and having issues, maybe I'll see if the maintainer wants to switch to rmarkdown and/or ask what specific features of knitrBootstrap he wants.