search

jimhester / knitrBootstrap

A framework to create bootstrap styled HTML reports from knitr Rmarkdown.
Other
274 stars 61 forks source link

Support Rmarkdown's tabbed navigation #187

Closed humburg closed 8 years ago

humburg commented 8 years ago

Rmardown now has support for tabbed navigation. That seems like a nice option to have and since knitrBootstrap is build on Rmarkdown anyway it is pretty straightforward to make it available here as well.

The only potential downside I see is that this may create a stronger dependency on a particular version of the Rmarkdown package. Since this requires the location of the javascript file in the Rmarkdown package any change to that would necessitate a change in knitrBootstrap. I don't think that is likely to be too arduous but it is one more thing that can break.

jimhester commented 8 years ago

True, but should be easy to update if need be. We should add an Rmarkdown version dependency to ( >= 0.9.5) to the DESCRIPTION file though, the navigation-1.0 rename was only added recently (https://github.com/rstudio/rmarkdown/commit/e5656dc2e774b329c357a8604ea11c79ed66f84f)

humburg commented 8 years ago

Good point about the Rmarkdown version. Should be all done now.