search

jimhester / knitrBootstrap

A framework to create bootstrap styled HTML reports from knitr Rmarkdown.
Other
274 stars 61 forks source link

Add well class to TOC #69

Closed srvanderplas closed 9 years ago

srvanderplas commented 9 years ago

I added the well class to toc elements in both knitrBootstrap.js and simple.js to mimic behavior in previous versions. image

jimhester commented 9 years ago

Thank you for the pull request! I originally took out the well class because I wasn't sure if people (or I) liked having it, but I will put it back. I am going to add it in https://github.com/jimhester/knitrBootstrap/blob/rmarkdown_template/inst/templates/default.html#L80 rather than adding javascript, because I am trying to use as little extra javascript as necessary. Thank you very much for the pull request though!

srvanderplas commented 9 years ago

Ah, ok. I knew you were trying to minimize JavaScript, but I didn't find the html template when I was poking through the files. Sweet, thanks!

On Wed, Oct 15, 2014 at 7:34 AM, Jim Hester notifications@github.com wrote:

Closed #69 https://github.com/jimhester/knitrBootstrap/pull/69.

— Reply to this email directly or view it on GitHub https://github.com/jimhester/knitrBootstrap/pull/69#event-178794472.