search

jimhigson / oboe.js

A streaming approach to JSON. Oboe.js speeds up web applications by providing parsed objects before the response completes.
http://jimhigson.github.io/oboe.js-website/index.html
Other
4.79k stars 208 forks source link

Ready: Standardize Style #161

Closed Aigeec closed 6 years ago

Aigeec commented 6 years ago

Kicking this off to resolve #123

Just pushing this file for now. This is the first issue I have come across when resolving issues found by applying standardjs. Hopefully the commit comments explain the change but if not let me know.

Aigeec commented 6 years ago

@JuanCaicedo All style issues are resolved and tests pass.

I would appreciate if you took a very close look at the "pass four" changes where a cast was needed.

For b67da0b please take a look here as a cast may be needed on both side, it depends on what name can be.

Aigeec commented 6 years ago

@JuanCaicedo if we could get this one merged in I have another one ready to go with the skipped tests running

Aigeec commented 6 years ago

@JuanCaicedo what is your preferred option for merges of the three Merge Commit, Squash, Rebase and Merge?

JuanCaicedo commented 6 years ago

@Aigeec Honestly, I usually just merge commit. I know a lot of projects use the other two, but I'm not sure we really need to worry about it that much. Feel free to merge!