search

jimhigson / oboe.js

A streaming approach to JSON. Oboe.js speeds up web applications by providing parsed objects before the response completes.
http://jimhigson.github.io/oboe.js-website/index.html
Other
4.79k stars 208 forks source link

test(streamingHttp): show fail and done being called together #166

Closed Aigeec closed 6 years ago

Aigeec commented 6 years ago

fixes #64

Will be implementing the same fix as others provided before. Have written tests to demonstrate the bug. The fix will in the next push.

Aigeec commented 6 years ago

Sorry about all the reverts. I pushed the fix to early and the first travis run didn't fail as intended. Then I reverted the wrong one. All sorted now. If a little messy. Could squash this merge :)

amit777 commented 5 years ago

Hi, is this fix planned to be merged into master and released? just got bit by the issue as well.

Aigeec commented 5 years ago

This was merged to master a year ago. What version are you using?

amit777 commented 5 years ago

Ahh, sorry yes, I see that. I think there hasn’t been a release since then. I’m using 2.1.4.

On Sat, Oct 5, 2019 at 2:51 PM Aodhagán Collins notifications@github.com wrote:

This was merged to master a year ago. What version are you using?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jimhigson/oboe.js/pull/166?email_source=notifications&email_token=AAUT7TLN3NS67BMWXOSPBC3QNED6BA5CNFSM4EWEDEYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAN4SDA#issuecomment-538691852, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUT7TN75GXBAWMK24J5BATQNED6BANCNFSM4EWEDEYA .

Aigeec commented 5 years ago

I think there was an alpha release.

@JuanCaicedo any reason not too do a full release?

JuanCaicedo commented 5 years ago

I've gone ahead and switched the 2.1.5 version from next to latest 😀