search

jimholgate / readtextextension

An Apache OpenOffice & LibreOffice extension to read text with an external program
19 stars 4 forks source link

Incorrect StarBASIC syntax: missing closing parenthesis #9

Closed mikekaganski closed 7 years ago

mikekaganski commented 7 years ago

With a recent changes in LibreOffice StarBasic parser (https://bugs.documentfoundation.org/show_bug.cgi?id=80731), it now doesn't silently accept a missing closing parenthesis anymore (as it did before). So, this change has revealed a number of extensions that had this flaw unnoticed (https://bugs.documentfoundation.org/show_bug.cgi?id=106529), Read Text being among them (https://ask.libreoffice.org/en/question/90653/after-upgrading-to-5312-previous-working-extensions-results-in-error/).

jimholgate commented 7 years ago

Thanks, Mike. Thanks for pointing out the flaw. This commit adds the closing parenthesis: