Bug: Impossible to disable inrun compass calibration

jiminghe / Xsens_MTi_ROS_Driver_and_Ntrip_Client

Xsens MTi ROS Driver and Ntrip Client, modified based on the 2023 official ROS Driver and added Ntrip Client

23 stars 8 forks source link

Bug: Impossible to disable inrun compass calibration #5

Closed ebnerluca closed 2 months ago

ebnerluca commented 3 months ago

https://github.com/jiminghe/Xsens_MTi_ROS_Driver_and_Ntrip_Client/blob/ab0031c63783e83d4b0dc458ef04c4177149945b/src/xsens_ros_mti_driver/src/xdainterface.cpp#L892C5-L902C6

^ Unreachable code. If enable_inrun_compass_calibration is false, then the whole section is skipped and inrun compass calibration does not get disabled. The same issue is present in other flags as well, e.g. enable_active_heading_stabilization and others.

ebnerluca commented 3 months ago

PR #6 should fix this. Tested for AHS and Inrun compass calibration flags, untested for the others.

jiminghe commented 3 months ago

Thank! merged to the main.