search

jimivdw / grunt-mutation-testing

JavaScript Mutation Testing as grunt plugin. Tests your tests by mutating the code.
MIT License
51 stars 11 forks source link

unit tests that run on original (unmutated) code should not be subjec… #26

Closed paysdoc closed 9 years ago

paysdoc commented 9 years ago

unit tests that run on original (unmutated) code should not be subject to a runner timeout

jimivdw commented 9 years ago

I'm doubting whether we should implement the unlimited runner time in this way, or whether we should make it work from the config object. We could make the runner time unlimited when config.waitForRunnerTime < 0. That way, we would also allow people to simply remove the timeout altogether, even for the mutation test runs.

We could then change the initial test runs in the KarmaCodeSpecsMatcher to be called with:

self._serverPool.startNewInstance(_.merge({waitForRunnerTime: -1}, config))

It's just a suggestion though, maybe it's better not to do it.

paysdoc commented 9 years ago

I did think of implementing it the way you suggest but decided against it. I don't think that it's a good idea to allow users to decide whether or not a runner should run for an unlimited time as it could cause havoc with their systems, and (GNU license not withstanding) we'll get the blame. Hence my preference for using a parameter as it cannot be configured from outside