search

jimivdw / grunt-mutation-testing

JavaScript Mutation Testing as grunt plugin. Tests your tests by mutating the code.
MIT License
51 stars 11 forks source link

Added notIncluded option for Karma options #61

Closed divido closed 8 years ago

divido commented 8 years ago

This is my simplistic way of getting the included flag set to false for certain files. Created to address #60

paysdoc commented 8 years ago

Looks fine to me. I'll just let Jimi check it too - he's done most of the work on the Karma part of the project.

jimivdw commented 8 years ago

Hi @divido,

Sorry for not coming back to you earlier. Your pull request regarding the karma.included option seems good. The esprima upgrade, however, I would like to see in a separate pull request (and it requires some more work as well, such as an escodegen upgrade, node version requirement upgrade, and more extensive testing). If you can reduce this pull request again to just the karma notIncluded part, I'm happy to merge and release a new version.

-- Jimi

divido commented 8 years ago

Sorry, about the sloppy pull request. I didn't understand how github was going to handle this. I'll close this and start a new pull request, hopefully with just the one change.