search

jimjam-slam / ggflags

A flag geom for ggplot2. Tweaks the original by using round flags (great for plotting as points).
92 stars 15 forks source link

"wrong" hue of blue for France and the Netherlands #23

Open paolocrosetto opened 1 year ago

paolocrosetto commented 1 year ago

Hi there,

I used your wonderful package to produce a plot that went viral on Twitter.

Dutch people are complaining that the NL flag is actually the Luxembourg flag. See for instance here: https://twitter.com/reinier_boon/status/1601625443530334208?s=20&t=n53cl8O-LT0uz27vCy0iOw

I realized the same lighter-blue-where-darker-blue-should-have-been problem is there for France too.

And nothing, just raising this here as I have no way of fixing this downstream.

Thank you for your work!

jimjam-slam commented 1 year ago

Thanks very much for the report! We've had a few reports of wrong flag colours. They've been patched manually thus far, as the source emoji set (EmojiOne Color) stopped being updated a while ago. (That has other problems that stack up over time, as you can imagine, like flags or countries changing outright!)

I'm hoping to do a 1.0 release for ggflag where we switch the backend to a different set of SVG tools, as I've started having problems with the backend scripts where we update flags.

I think it probably makes sense to use that opportunity to update the source flag dataset! I'm eyeing up https://github.com/HatScripts/circle-flags as a potential candidate (See #17), as it's one of the few sets of circular flags.

Thank you for your patience on this!

jimjam-slam commented 1 year ago

(And congratulations on the popularity of the graphic! 🥳)