search

jimjkelly / missile-defense

http://missile.exchange
1 stars 0 forks source link

Clean Up UI #7

Open jimjkelly opened 7 years ago

jimjkelly commented 7 years ago

Once all of our UI elements are in place and working we'll want to spruce up how it looks. Add sufficient whitespace between elements, ensure things consistently sit on the same lines, ensure good behavior on screen resize, etc.

wslafoy commented 7 years ago

Not sure if UI or UX, but the user can currently input numbers that are too high for some of the variables, ex. SSPK should only be between 0 and 1. Not a major issue though

jimjkelly commented 7 years ago

I actually meant to ask you whether there were limits you wanted to put on various fields. If there are any others let me know, I can add them on.

wslafoy commented 7 years ago

Will do!

jimjkelly commented 7 years ago

Okay, I've been working on this today, coupling it with a little help thing for each field to provide some information about what the value is and acceptable values. Hope to have it checked in tomorrow. Also have some work on the layer coloration based on probability done.

Hope the finals went well!

jimjkelly commented 7 years ago

Just an update - get stuck on another project today so I didn't get to it, but should have an update tomorrow.

wslafoy commented 7 years ago

No worries. I've been working through the hosting stuff, which I think I have finally worked out, huzzah

jimjkelly commented 7 years ago

Okay, the latest validation is up for the fields. Each is checked against a boolean expression, as seen for example here (that ensures it's an integer over one) and here (that ensures it's between 0 and 1 inclusive) . There's also a little question mark thing that when you click on it a popover shoots up explaining what it is, and the accepted values. Like everything else it needs a bit of design tightening, sometimes it goes partially off the screen and it needs whitespace and such, but we'll clean that up at the end.

Changes are live here: http://missile-defense.s3-website-us-west-2.amazonaws.com/

wslafoy commented 7 years ago

Tested, works! Awesome

wslafoy commented 7 years ago

Something to add in general UI cleanup: Users indicate confusion over the variables. A legend may be necessary at one point. May be a good idea to make it toggle-able for real estate purposes

wslafoy commented 7 years ago

An easy one that will make testing with users immediately better: The "Numbers" variable in both offensive layers is now extraneous and can be deleted. The "Interceptors" variable in the Defensive layer should be "Interceptors per Target"

jimjkelly commented 7 years ago

Okay, changes made and pushed live.

wslafoy commented 7 years ago

I'm going to start doing some minor changes to the UI content, but only very basic stuff (like the descriptions on the ? boxes. no style changes, just content strings) as I try to figure out what is the most easy to understand stuff for users.

Should I set up a separate branch to do these edits? Both for tracking purposes and to idiot-proof the main branch?

(also most recent update is awesome. The layer system works great and everything seems to be moving and interacting cleanly!)

jimjkelly commented 7 years ago

It's up to you - if you feel comfortable with the changes and they're simple then you can probably put them right on the main branch. If you want me to review them first, I'd say start a new branch and then create a pull request against master and I can give them a quick gander.

And glad to hear the layer stuff is working well!

wslafoy commented 7 years ago

Cool. I'll make a new branch for now (Also as an excuse to play with branches. I'm still terrible at git)

jimjkelly commented 7 years ago

Ha, well if you have any questions feel free to let me know. You can send me a message on gchat if you want a more real time response.

wslafoy commented 7 years ago

Will do!

Also I may not be added as a collaborator, I can't start new branches apparently

jimjkelly commented 7 years ago

oh, oops! just added you, you should have an invite now.

wslafoy commented 7 years ago

No prob, thanks!

jimjkelly commented 7 years ago

So just to confirm, I think that most of the feature work is done, and what's left is this issue, #28, #15, #12, and #6. Is that correct? Anything else?

I'll get started on UI clean up and browser compatibility next.

jimjkelly commented 7 years ago

Oops, didn't mean to close this one.

jimjkelly commented 7 years ago

So looking at this a bit - how do you feel about potentially making the offense/defense widgets on right unified into a single column, and you can select which type you want to add, and then combining the layer ordering into that? I'm just thinking it may give us some horizontal breath space and be a bit easier to organize, and also easier to perhaps eventually change into something that will work on mobile.

wslafoy commented 7 years ago

That's not a bad idea, but I want to make sure that the offense and defense layers are very cleanly separated somehow.