search

jimkyndemeyer / react-css-modules-intellij-plugin

React CSS Modules support in IntelliJ IDEA and WebStorm for components written in JavaScript and TypeScript.
MIT License
41 stars 5 forks source link

Falsely flags -ms-grid repeat notation #9

Open Bill-ratehub opened 5 years ago

Bill-ratehub commented 5 years ago

Something like -ms-grid-rows: (1fr)[8]; is valid syntax for defining grid rows for the early and non-standard CSS grid layout supported by IE11. However, this plugin flags it as an error with ']' expected / a term expected.

It'd be great if IE11 would just disappear, so that we be the preferred solution. But, more pragmatically, it'd be great if this -ms-grid syntax was not flagged when someone tries to help IE11 participate in modern grid layouts.

jimkyndemeyer commented 5 years ago

Hi Bill.

The only annotations that this plugin provides are for unknown classes: https://github.com/jimkyndemeyer/react-css-modules-intellij-plugin/blob/70810955c9a67ce3a3515fb4660ff651ee6cf524/src/main/com/intellij/react/css/modules/ide/annotator/CssModulesClassAnnotator.java#L50

The error you've included sounds like the output of a parser that encounters a syntax error.

Does the error go away if you disable this plugin?

Bill-ratehub commented 5 years ago

Hi Jim!

Well, I almost started my issue with "I'm not sure but, I think your plug-in…". I find it hard to know exactly who is in charge of what when it comes to things going on inside JetBrains editors. I did disable your plug-in, restarted, and I did not see the message, so that had me jump to that conclusion.

On Thu, Dec 20, 2018 at 11:55 AM Jim Kynde Meyer notifications@github.com wrote:

Hi Bill.

The only annotations that this plugin provides are for unknown classes:

https://github.com/jimkyndemeyer/react-css-modules-intellij-plugin/blob/70810955c9a67ce3a3515fb4660ff651ee6cf524/src/main/com/intellij/react/css/modules/ide/annotator/CssModulesClassAnnotator.java#L50

The error you've included sounds like the output of a parser that encounters a syntax error.

Does the error go away if you disable this plugin?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jimkyndemeyer/react-css-modules-intellij-plugin/issues/9#issuecomment-449064873, or mute the thread https://github.com/notifications/unsubscribe-auth/AqtlfMsj78jlDrEPCjrW6rjWXDzw2Sd5ks5u68ELgaJpZM4Zch7r .

-- Bill LucasSr Front-End Engineer http://ratehub.ca/ E: bill.lucas@ratehub.ca bill.lucas@ratehub.ca Ratehub - P: 1.800.679.9622 <1-800-679-9622> facebook https://www.facebook.com/RateHub twitter https://twitter.com/ratehub linkedIn http://www.linkedin.com/in/ instagram https://www.instagram.com/ratehub/ youtube https://www.youtube.com/user/RateHub