search

jimlindstrom / FinModeling

Tools for Financial Modeling
101 stars 32 forks source link

Upgrade gsl version to 1.15 #6

Closed ghg closed 10 years ago

ghg commented 10 years ago

I noticed Ubuntu 13.04 version was 1.15, so I tried it on OSX and it worked as well.

@jimlindstrom, do all of your tests pass? I get:

415 examples, 24 failures, 12 pending
jimlindstrom commented 10 years ago

Gregory - Sorry for the slow response. Was away for the holiday weekend.

I just re-ran "rake test" on my development machine, and 36 tests are failing.

I believe that some tests may be badly written such that they test things about "the last filings for company ". I wouldn't be surprised if those tests are broken and need re-thought. However, there are a lot more tests broken than I would have expected just from that.

(For reference, my dev machine is OS X. My gsl gem version is 1.15.3. And brew reports that I have version 1.15 installed.)

I can take a look at these failures this week. I suspect they're relatively easy to fix and I can get to that tomorrow night. Let me look at those before addressing this pull request.

jimlindstrom commented 10 years ago

Alright, I'm down to two failing tests, on my dev machine: 

Failures:

  1) FinModeling::CAPM::Beta#from_ticker returns the right value
     Failure/Error: FinModeling::CAPM::Beta.from_ticker(company_ticker, num_days).should be_within(0.1).of(expected_beta) # FIXME: this is now ignorant of dividends...
     RuntimeError:
       no index returns
     # ./lib/finmodeling/capm.rb:46:in `from_ticker'
     # ./spec/company_beta_spec.rb:50:in `block (3 levels) in <top (required)>'

  2) FinModeling::ReformulatedIncomeStatement#forecast_next should set operating_revenue to last year's revenue
     Failure/Error: subject.operating_revenues.total.should be_within(0.1).of(expected_val)
       expected 49430740348.52138 to be within 0.1 of 54512000000.0
     # ./spec/reformulated_income_statement_spec.rb:276:in `block (3 levels) in <top (required)>'

Finished in 161.09 seconds
412 examples, 2 failures, 14 pending

Are you seeing similar behavior?

ghg commented 10 years ago

Yep, I'm seeing the same on master now:

Finished in 214.83 seconds
412 examples, 2 failures, 14 pending

However, if I do a clean run (rm -rf ~/.finmodeling) I have this:

Finished in 810.05 seconds
412 examples, 4 failures, 14 pending
jimlindstrom commented 10 years ago

Okay. I'm going to merge this and your other request, and then I'll open up my own issue for the remaining failing specs. I appreciate your help, Gregory.