jimmcg / tabgroupsmanager

Automatically exported from code.google.com/p/tabgroupsmanager
0 stars 0 forks source link

"Close Left Tabs (in group)" and "Close Right Tabs (in group)" in Tab Context Menu may be missing #119

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Before submitting the issue, please check that your version of TabGroups
Manager is the lastest stable one. (Check it in Firefox Extensions).

What steps will reproduce the problem?
1. Right-click a tab
2.
3.

What is the expected output? What do you see instead?
If the options are enabled, "Close Left Tabs (in group)" and "Close Right Tabs 
(in group)" in Tab Context Menu should always show, intermittently they totally 
don't show

System Info:
What version of TabGroups Manager are you using?
beta 105
What Operative System are you using? 32 or 64 bits?
win7 home premium sp1 64bit
What version of Firefox are you using?
Have tried all versions from 33 to 38.0.6
Are you using any other tab extension like Colorfull tabs, Multiple Tab
Handler, TabMix Plus..?
Have tried in 2 separate profiles with and without Multiple Tab
Handler, TabMix Plus, the problem remained the same 

Please provide any additional information below and screens capture if
possible.

Original issue reported on code.google.com by cybe...@gmail.com on 16 Jun 2015 at 3:56

GoogleCodeExporter commented 8 years ago
Will be displayed here and is working fine.

Original comment by micha.gm...@arcor.de on 18 Jun 2015 at 7:32

GoogleCodeExporter commented 8 years ago
I use portable firefox, don't think this should make a difference than the 
normal installation. 
http://portableapps.com/apps/internet/firefox_portable

I notice that not only the said items can be missing, but indeed it's the whole 
tab context menu from TGM that may be missing, so I made a fresh installation 
of portable firefox 38.0.5 with TGM beta 5 as the only extension, the problem 
remained. 

Please note this is an intermittent issue, meaning sometimes happens sometimes 
not. To reproduce it, you have to make cold start of firefox, a hot-restart of 
the current firefox session will maintain the same status as the initial start. 

My tests show that for the cold starts of firefox, most of the time you get the 
problem. 

Also note I only spot this issue with beta 5 since 6 months ago, all previous 
versions don't have the problem in my years of using TGM, if I downgrade to 
beta 4 in same firefox profile, the issue is immediately gone, but beta 4 
doesn't work with latest Tab Mix Plus Dev build. The close left or right tabs 
in group can be achieved with TMP but the functionality "Send to other group" 
still suffers. 

Original comment by cybe...@gmail.com on 19 Jun 2015 at 3:35

GoogleCodeExporter commented 8 years ago
Do you use themes?

Original comment by micha.gm...@arcor.de on 19 Jun 2015 at 7:25

GoogleCodeExporter commented 8 years ago
Please check also browser console for TGM related error messages. 
Open this with SHIFT+STRG+j.

Original comment by micha.gm...@arcor.de on 19 Jun 2015 at 8:37

GoogleCodeExporter commented 8 years ago
I've tried fresh installations without any customization, checked browser 
console before and after TGM installed (the only add-on introduced): 
1. Portable Firefox 38.0.5
2. Firefox 38.0.6
The problem persisted exactly the same as I found from portable Firefox 33 to 
39b7. 

In other words, there is no theme involved and no error message for TGM at all. 

I tend to believe some bugs were introduced in TGM beta 5 without causing any 
error message being logged, so a diff between beta 5 & beta 4 should be closer 
to finding the problem. 

@micha.go...@arcor.de, btw, did you install portable Firefox to try? If yes, 
can you reproduce the bug?

Original comment by cybe...@gmail.com on 20 Jun 2015 at 4:18

GoogleCodeExporter commented 8 years ago
Download the tabgroupsmanager.jar and the tabgroupsmanager.jsm from module dir 
from SVN repo, replace the files in your tgm extension dir and check.

Original comment by micha.gm...@arcor.de on 20 Jun 2015 at 4:37

GoogleCodeExporter commented 8 years ago
Have tried to replace the files in the existing profile, problem remained, so I 
packaged the files into beta 5 to make a new xpi, then installed into a fresh 
Firefox profile, it behaved exactly the same

Original comment by cybe...@gmail.com on 21 Jun 2015 at 2:07

GoogleCodeExporter commented 8 years ago
I confirm that this occurs on cold start on Fx 38. On restart after addon 
install is there no problem. In ervery case it seems to be fixed on actual 
nightly. there is all ok. I use the tab menu seldom, so it seesms that i have 
it not seen in the last months...

Please download a Nightly build from mozilla FTP. At the moment the Nightly is 
very crashy with E10s and disabled HWA. Depends from your hardware 
constellation. 
I would recommend to take the nightly from 17.6.15. Take the win32 zip file 
also if you have x64 and place it in the folder of your portable firefox 
location. There must also be a folder called firefox. Disable updates on your 
new portable nightly and disable e10s in options.

If you confirm that its fixed with nightly i will check the regression range. 

Original comment by micha.gm...@arcor.de on 21 Jun 2015 at 12:22

GoogleCodeExporter commented 8 years ago
Nightly:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-06-17-03-02-05-mozil
la-central/firefox-41.0a1.en-US.win32.zip

Original comment by micha.gm...@arcor.de on 21 Jun 2015 at 12:24

GoogleCodeExporter commented 8 years ago
With the tabgroupsmanager.jar and the tabgroupsmanager.jsm from module dir from 
SVN repo, I've tried both nightly 17.6.15 and 21.6.15, they both work fine 
without this bug

Original comment by cybe...@gmail.com on 21 Jun 2015 at 3:25

GoogleCodeExporter commented 8 years ago
Ok i will check the next days what has caused this.

Original comment by micha.gm...@arcor.de on 21 Jun 2015 at 8:58

GoogleCodeExporter commented 8 years ago
Made still some changes the last days. Maybe you can test it again with both 
actual files mentioned above from svn and test with fx 38.0.5.

Original comment by micha.gm...@arcor.de on 24 Jun 2015 at 7:34

GoogleCodeExporter commented 8 years ago
Have tried with portable fx 38.0.5 and 39rc4, the problem remains, sorry

Original comment by cybe...@gmail.com on 25 Jun 2015 at 3:38

GoogleCodeExporter commented 8 years ago
Hm. At the moment i can it not reproduce this on 38.05 portable...

Original comment by micha.gm...@arcor.de on 25 Jun 2015 at 6:23

GoogleCodeExporter commented 8 years ago
Have tried again with portable fx 38.0.5 and 39rc4 in fresh fx profiles, the 
problem remains. 

If you have fx nightly running, now you run portable fx 38.0.5, it will create 
an instance of the nightly instead of fx 38.0.5, then your test will be against 
the nightly. To prevent this, please make sure you close all instances of fx, 
then start portable fx, you should get the bug now. 

Original comment by cybe...@gmail.com on 26 Jun 2015 at 2:00

GoogleCodeExporter commented 8 years ago
Have further tested with portable fx 38.0.5 on xpsp3 pc,the problem remains.

Original comment by cybe...@gmail.com on 27 Jun 2015 at 3:57

GoogleCodeExporter commented 8 years ago
Enable in Fx options "start with last session" or similar and check again.

Original comment by micha.gm...@arcor.de on 27 Jun 2015 at 8:17

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
You are right! With this option, the bug is gone. I've tried on portable fx 
38.0.5 & 39rc5. The other 2 options "Show my home page" & "Show a blank page" 
will always trigger the bug. On a fresh fx installation, the default option is 
"Show my home page"

Original comment by cybe...@gmail.com on 28 Jun 2015 at 1:58

GoogleCodeExporter commented 8 years ago
Added a fix to SVN. Please download the both above mentioned files again.

Original comment by micha.gm...@arcor.de on 29 Jun 2015 at 7:42

GoogleCodeExporter commented 8 years ago
I've tried on portable fx 38.0.5 & 39rc5, I can confirm the bug is fixed now! 
Thank you

Original comment by cybe...@gmail.com on 30 Jun 2015 at 2:18