Closed danielesalvatore closed 5 years ago
Hi, this is not the issue of this project and your problem is because of instant client not install correctly locally I guess. if you running locally, you have to install node-oracledb as dev dependency , I have been using 12.1 and this project is based on 12.1. here is the list of required files for instant client on mine opt/oracle/instantclient_12_2 and ~/lib directory. Please let me know if you are run into any issue that this won't work on lambda. I'll close this for now and hope these information will be helpful. If you are still struggling, I can see if I will have time to test on 18 later next week. but I have no plan to support 18 right now.
Dear @jimmdd Thank you very much for your prompt reply and support!!
This problem seemed to be related to serverless-webpack
or the webpack
configuration I used. I removed the plugin and now the binary is loaded correctly.
On Monday, I'll keep troubleshooting this and will post here the solution for future reference.
Thank you again!
@danielesalvatore Thanks. The current repo doesn't have webpack configured but I do have other projects with orabledb and webpack. I'll update the repo with it this weekend. Please check back on Monday compare my webpack configs and yours. If my settings are still not working for you, please do a PR if you could to add your webpack settings once you have correct webpack.
@danielesalvatore I have updated branch feature/add_webpack, please try it and let me know if that works for you. I've test on my local and everything works. If it's work for you, I'll merge it into master. Please see the following PR: #3
Hi @jimmdd! I confirm that it works perfectly! Thank you very much for this! Please do not hesitate to contact me in case you need any additional testing!
The only thing I noticed is that you removed the webpack
configuration from serverless.yml
file, while I kept it in order to exclude from the bundle some other libs, as suggested in the serverless-webpack
doc.
Thanks!
Hi @jimmdd! I confirm that it works perfectly! Thank you very much for this! Please do not hesitate to contact me in case you need any additional testing!
The only thing I noticed is that you removed the
webpack
configuration fromserverless.yml
file, while I kept it in order to exclude from the bundle some other libs, as suggested in theserverless-webpack
doc.Thanks!
OK that custom webpack session is optional. But I'll update the Yaml with the webpack session.
Hi @jimmdd ! Thank you very much for your work!
I am currently struggling making
node-oracledb
to work on mynode
10.16.2serverless
1.49.0serverless-offline plugin
5.10.1serverless-webpack
5.3.1webpack
4.39.1node-oracledb
4.0.0Please find below the error I get while i make run the
serverless-offline
locally:Content of
~/lib
: (tried to alter permission to be 777 to exclude file system permission problems)~/lib
in the my$PATH
I followed the Oracle instructions: link
Thank you very much in advance, Daniele