jimmejardine / qiqqa-open-source

The open-sourced version of the award-winning Qiqqa research management tool for Windows
GNU General Public License v3.0
380 stars 64 forks source link

Web Browser/Sniffer: Web Preferences are not remembered + typo in tooltip #44

Closed GerHobbelt closed 5 years ago

GerHobbelt commented 5 years ago

2019-08-14

  1. 'Save Preferences' doesn't seem to work; every time Qiqqa opens another Sniffer, the standard tabs are opened and not the set which has been selected in this Preferences dialog.

  2. 'PDFF' at the end of the tooltip for the Save button.

GerHobbelt commented 5 years ago

Fixed in commit SHA-1: 989b7b308c74e3c8e18ca778aa7abb03cd2687e5 (which doesn't mention it; forgot to add to commit mssage)

The key here was to refactor ForceSnifferSearchers() and related code: the saved configuration should ALWAYS at least add the configured entries and not be discarded when a 'forced' minimal set is also required.

GerHobbelt commented 5 years ago

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, pending #15 / any maintainer rights/actions.