search

jimmod / ShareToComputer

GNU General Public License v3.0
143 stars 29 forks source link

[Bug] Fix crash when selecting media/file & Fix white empty screen after go to About screen #58

Closed jimmod closed 4 years ago

jimmod commented 4 years ago

[Bug] Fix crash when selecting media/file Cause: NPE when accessing map content. FragmentHelper can be destroyed & recreate and the variable map will be empty Solution: Make map variable as static

[Refactor] Remove QrCodeFragment and put the logic in ReceiveViewModel Remove ActivityExt, move startQrCodeScan to ActivityHelper [Bug] Fix white empty screen after go to About screen

codecov[bot] commented 4 years ago

Codecov Report

Merging #58 into master will increase coverage by 2.88%. The diff coverage is 62.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
+ Coverage     65.94%   68.82%   +2.88%     
  Complexity        4        4              
============================================
  Files            38       37       -1     
  Lines           966      956      -10     
  Branches        142      141       -1     
============================================
+ Hits            637      658      +21     
+ Misses          227      187      -40     
- Partials        102      111       +9
Impacted Files Coverage Δ Complexity Δ
.../jim/sharetocomputer/ui/setting/SettingFragment.kt 79.16% <ø> (ø) 0 <0> (ø) :arrow_down:
...va/com/jim/sharetocomputer/ui/main/MainActivity.kt 81.81% <ø> (ø) 0 <0> (ø) :arrow_down:
...tocomputer/webserver/InputStreamNotifyWebServer.kt 100% <ø> (ø) 0 <0> (ø) :arrow_down:
...n/java/com/jim/sharetocomputer/ui/DummyActivity.kt 100% <100%> (ø) 0 <0> (?)
...p/src/main/java/com/jim/sharetocomputer/Modules.kt 93.75% <100%> (+0.41%) 0 <0> (ø) :arrow_down:
...im/sharetocomputer/ui/receive/ReceiveNavigation.kt 18.75% <14.28%> (-22.92%) 0 <0> (ø)
...jim/sharetocomputer/ui/receive/ReceiveViewModel.kt 62.5% <50%> (-2.72%) 0 <0> (ø)
...va/com/jim/sharetocomputer/ui/main/MainFragment.kt 87.5% <66.66%> (ø) 0 <0> (ø) :arrow_down:
.../com/jim/sharetocomputer/gateway/ActivityHelper.kt 71.73% <74.07%> (+8.58%) 0 <0> (ø) :arrow_down:
...ain/java/com/jim/sharetocomputer/ext/ContextExt.kt 61.36% <0%> (-2.28%) 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa7ab71...af14b16. Read the comment docs.