search

jimmoores / quandl4j

Java wrapper for Quandl REST API
quandl4j.org
Apache License 2.0
78 stars 22 forks source link

Why does dataset retrieval use api/v1? #24

Closed weaselmetal closed 7 years ago

weaselmetal commented 7 years ago

Hey Jim,

I saw that session.getDataSet() will query api/v1, same for getMetaData(). session.search() will use api/v3. Why do the former use v1? Any plans to support v3 for all requests?

Thanks, Stefan

jimmoores commented 7 years ago

To be honest, I just haven't gotten around to transitioning everything to the v3 API yet (no idea what happened to v2, presume it was internal). Happy to take a look at it and see if I can get it updated within the next day or so.

On 18 Jan 2017 4:03 p.m., "weaselmetal" notifications@github.com wrote:

Hey Jim,

I saw that session.getDataSet() will query api/v1, same for getMetaData(). session.search() will use api/v3. Why do the former use v1? Any plans to support v3 for all requests?

Thanks, Stefan

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jimmoores/quandl4j/issues/24, or mute the thread https://github.com/notifications/unsubscribe-auth/AADG-19I31FZk4OcdIqdN6yPqWiBXUeIks5rTjfDgaJpZM4LnD6k .

weaselmetal commented 7 years ago

Nice! Thanks Jim! Feel free to close this question any time you consider appropriate.

jimmoores commented 7 years ago

Clearly I haven't been able to get to it as quickly as I hoped, I'll try and schedule and time to work on it soon. Do you have any specific time constraints or was it a more general query?

weaselmetal commented 7 years ago

It was a general inquiry. api v3 doesn't add anything I'd desperately need as of now. I was more puzzled by the fact that different api versions are being used. As far as I saw, api v3 simply returns more data.

benmccann commented 7 years ago

This is fixed now in master

jimmoores commented 7 years ago

Thanks to Ben McCann for fixing this.