search

jimmoores / quandl4j

Java wrapper for Quandl REST API
quandl4j.org
Apache License 2.0
78 stars 22 forks source link

Upgrade dependencies. Remove logback from classpath #26

Closed benmccann closed 7 years ago

benmccann commented 7 years ago

I did not upgrade testng because the newest version requires Java 8 and I wasn't sure if you wanted to drop Java 7 support

It's great that this library uses slf4j for logging. The benefit of using slf4j is that the logging implementation becomes pluggable. Thus, we don't want to include logback on the main runtime classpath so that users can use whatever implementation they choose. I've moved logback to the test scope so that quandl4j uses it for its own tests, but users can use any alternative they choose.

jimmoores commented 7 years ago

Many thanks for this, very thoughtful of you to check Java 7 compatibility too.