search

jimmyconti / nettopologysuite

Automatically exported from code.google.com/p/nettopologysuite
0 stars 0 forks source link

GeometricShapeFactory.Dimensions.getCircle behavior #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
With JTS r675: http://sourceforge.net/p/jts-topo-suite/code/675 
Dimensions.getCircle implementation has changed. Now "base" property is ignored 
when computing "circle".
NTS should be consistent with this.

NOTE: reported by shawty in google group: 
https://groups.google.com/d/msg/nettopologysuite/hUJYrxmAsno/qxw9HaogJqwJ

Original issue reported on code.google.com by diegogu...@gmail.com on 26 Jun 2014 at 6:34

GoogleCodeExporter commented 9 years ago 
although NTS implementation is different from JTS one, NTS behavior looks 
correct, and works also is able to avoid NullReferenceExceptions.

Original comment by diegogu...@gmail.com on 26 Jun 2014 at 6:40

GoogleCodeExporter commented 9 years ago

Original comment by diegogu...@gmail.com on 26 Jun 2014 at 6:40

GoogleCodeExporter commented 9 years ago 
after a little bit of investigation, NTS implementation looks valid and 
consistent with JTS one.

Original comment by diegogu...@gmail.com on 26 Jun 2014 at 6:50

GoogleCodeExporter commented 9 years ago 
If the GeometricShapeFactory.Dimensions.getCentre() is the same as in NTS then 
we should report that to JTS.

Original comment by felix.ob...@netcologne.de on 27 Jun 2014 at 7:08

GoogleCodeExporter commented 9 years ago 
ah ok, so I've simply misunderstood the NTS code and I haven't see the bug :(

Original comment by diegogu...@gmail.com on 27 Jun 2014 at 7:36

GoogleCodeExporter commented 9 years ago 
JTS code checks for "centre == null" exactly as JTS now, simply I've made a lot 
of confusion with this code.

Original comment by diegogu...@gmail.com on 27 Jun 2014 at 7:37

GoogleCodeExporter commented 9 years ago 
felixm this is for you :)
http://thecodinglove.com/post/49761335518/changed-one-line-of-code-bug-is-fixed

Original comment by diegogu...@gmail.com on 27 Jun 2014 at 8:11