jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
130 stars 27 forks source link

get_footywire_betting_odds starts some seasons at Round 0 #102

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

When calling get_footywire_betting_odds() with the full season range (2010 to 2019), seasons 2017 through 2019 start at Round 0 instead of 1 due to a bug in how cumulative round lags are calculated, because the calculations are not properly grouped by season, leading to cumulative lags to leak from one season to the next.

I'm working on a PR with a fix this.