jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

Calculate cumulative lag by Season group #103

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

Resolves #102

Not separating out the nesting by Season and Round led to calculating round lag (due to bye weeks) across seasons, resulting in seasons 2017 through 2019 starting with a Round of zero.

jimmyday12 commented 4 years ago

Thanks @cfranklin11! Real shame that round number isn't part of the dataset we are scraping but this looks good to me. I'll merge.

Quick note - I'm playing around with github actions which are pretty nice but still not quite as built out as travis-ci. So don't worry too much about any of those tests failing