A fix to how cumulative round lag was calculated across seasons resulted in a new bug in how cumulative round lag was calculated after a bye week. This caused an inflated cumulative lag number, which resulted in round numbers that went up and down and up again.
In addition to fixing this particular bug, I reorganised the relevant tests in an effort to catch these kinds of regressions in the future. Loading multiple seasons of betting data and making assertions on general characteristics of the data should do a better job of catching future bugs than the more specific tests for edge cases.
Resolves #104
A fix to how cumulative round lag was calculated across seasons resulted in a new bug in how cumulative round lag was calculated after a bye week. This caused an inflated cumulative lag number, which resulted in round numbers that went up and down and up again.
In addition to fixing this particular bug, I reorganised the relevant tests in an effort to catch these kinds of regressions in the future. Loading multiple seasons of betting data and making assertions on general characteristics of the data should do a better job of catching future bugs than the more specific tests for edge cases.