Round 13 in 2010 and round 18 in 2014 span two weeks, which means we were labelling them as two separate rounds, which increased the round number for all subsequent rounds. Also, the 2010 Grand Final was played twice due to a draw, resulting in the same issue.
This fixes up the offending round numbers similarly to how we handle other special cases of the AFL's scheduling inconsistencies and adds a couple of tests.
On a side note, these round number bugs are difficult to catch on their own, and I've been finding most of them when running the Footywire betting data through my full data pipeline, because various transformations and joins depend on absolute consistency. To be on the safe side, I ran these changes through the entire pipeline (I had been too lazy to do it before), and it completed without error. So, I'm hopeful this will be the last round-related bug fix for awhile.
Resolves #106
Round 13 in 2010 and round 18 in 2014 span two weeks, which means we were labelling them as two separate rounds, which increased the round number for all subsequent rounds. Also, the 2010 Grand Final was played twice due to a draw, resulting in the same issue.
This fixes up the offending round numbers similarly to how we handle other special cases of the AFL's scheduling inconsistencies and adds a couple of tests.
On a side note, these round number bugs are difficult to catch on their own, and I've been finding most of them when running the Footywire betting data through my full data pipeline, because various transformations and joins depend on absolute consistency. To be on the safe side, I ran these changes through the entire pipeline (I had been too lazy to do it before), and it completed without error. So, I'm hopeful this will be the last round-related bug fix for awhile.