Return empty data frame if data set is blank

jimmyday12 / fitzRoy

A set of functions to easily access AFL data

https://jimmyday12.github.io/fitzRoy

Other

129 stars 27 forks source link

Return empty data frame if data set is blank #113

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

Resolves #112

In the case of only requesting a season that hasn't been played yet, the NULL returned by unlist caused an error later in the chain of functions. This handles empty data more gracefully.

cfranklin11 commented 4 years ago

The test failures appear to be due to some flakiness in testing update_footywire_stats. I ran both the full check and that test specifically on my machine and they passed.

jimmyday12 commented 4 years ago

Thanks @cfranklin11. I've been playing around with github actions which is the reason for most of those checks.

Also - there seems to be something broken in old R builds (3.3 and 3.4) that was failing before this PR so happy to ignore those failed tests. I'm going to try fix that over the weekend but will merge this in for now