search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
130 stars 27 forks source link

Added fryziggafl-player_stats.R and helper.R to call www.fryziggafl.n… #119

Closed Fryzigg closed 4 years ago

Fryzigg commented 4 years ago

…et/api/ to return some extra information including AFLStatsPro data.

jimmyday12 commented 4 years ago

@Fryzigg I'll take a look over the next few days. But in general if you could add unit tests that would be helpful. You can see some examples in the 'tests' folder but the easiest way to set things up would be run

usethis::use_test("fryzigg_api") and add tests there.

Fryzigg commented 4 years ago

Just added some simple unit tests, will add some more later checking for stat's that will never change etc, following the same as the AFL Tables one. Have added a caching mechanism too to increase pulling times.

Fryzigg commented 4 years ago

Is there anything further you need me to do?

jimmyday12 commented 4 years ago

Is there anything further you need me to do?

We need to get the above checks all passing. I actually think there might be an issue with the master branch as well so I'll try fix that this week and see if it fixes them before we merge this in.