search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

Added AFLW stats and test. #121

Closed Fryzigg closed 4 years ago

jimmyday12 commented 4 years ago

Looks good to me - can you just add a bullet point to the NEWS.md file and I'll merge it in

Fryzigg commented 4 years ago

Looks good to me - can you just add a bullet point to the NEWS.md file and I'll merge it in

Like that?

Fryzigg commented 4 years ago

Function isn't available within the development version of the package, believe because namespace hasn't been updated. Is there any extra step i need to take in the future to make functions callable.

jimmyday12 commented 4 years ago

A good practice is to run devtools::check(document = TRUE) - this should run all checks but also update the namespace if needed. I can do that on Master now to update it

Fryzigg commented 4 years ago

Cool noted, thanks. Will do this in the future.