Add Match.ID column to guarantee unique ID columns for pivot

jimmyday12 / fitzRoy

A set of functions to easily access AFL data

https://jimmyday12.github.io/fitzRoy

Other

130 stars 27 forks source link

Add Match.ID column to guarantee unique ID columns for pivot #122

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

With the limited number of venues for the current rounds, the AFL has scheduled two matches for the same venue on the same day, which breaks the uniqueness assumption for those value combinations. Adding an ID column to facilitate pivoting fixes the error raised from duplication causing team columns to have vectors of names instead of individual team names.

jimmyday12 commented 4 years ago

Thanks @cfranklin11!

Looks good to me - the older linux checks are failing in the master branch due to an issue with rmarkdown that should be resolved soon so we can ignore them for now (see https://github.com/rstudio/rmarkdown/issues/1831)

Can you just add a bullet point to NEWS.md and then I will merge in?