jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
130 stars 27 forks source link

Compact AFL schedule results in incorrect round numbers for 2020 #125

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

Since get_fixture() uses week-of-year to calculate round numbers, the new, compressed AFL schedule messes with that, because the only thing better than one round of footy per week is two rounds of footy per week.

Below is a copy/paste of the last 10 rows. According to footywire, round 12 should start on 2020-08-13, but it's still "week 11".

# A tibble: 10 x 7
   Date                Season Season.Game Round Home.Team       Away.Team      Venue         
   <dttm>               <dbl>       <int> <dbl> <chr>           <chr>          <chr>         
 1 2020-08-12 19:10:00   2020           1    11 Gold Coast      Essendon       Carrara       
 2 2020-08-13 18:10:00   2020           1    11 Sydney          GWS            Perth Stadium 
 3 2020-08-14 19:50:00   2020           1    11 Geelong         Port Adelaide  Gabba         
 4 2020-08-15 14:35:00   2020           1    11 North Melbourne Brisbane Lions Bellerive Oval
 5 2020-08-15 17:10:00   2020           1    11 Melbourne       Collingwood    Gabba         
 6 2020-08-15 18:10:00   2020           1    11 Fremantle       Carlton        Perth Stadium 
 7 2020-08-16 13:05:00   2020           1    11 Footscray       Adelaide       Carrara       
 8 2020-08-16 15:35:00   2020           1    11 St Kilda        Essendon       Gabba         
 9 2020-08-16 16:10:00   2020           1    11 West Coast      Hawthorn       Perth Stadium 
10 2020-08-17 19:10:00   2020           1    11 Richmond        Gold Coast     Gabba 

I've implemented fixes for similarly-irregular rounds before, so I'll work on a fix, and should have a PR soon.

jimmyday12 commented 4 years ago

I was thinking this would be the case. Thanks @cfranklin11