search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

Winning team incorrectly always listed as home team in finals in function `get_match_results` #127

Closed rwarneke closed 4 years ago

rwarneke commented 4 years ago

get_match_results always lists the winner as the home team in finals matches - note the margin is always positive for finals.

This is presumably because the file here does the same. Although this file does not appear to make a guarantee that home teams are listed first, I've let the AFLtables owner know.

It's worth noting that get_fixture gets the home team correct for all matches, including finals. It could be used to fix this issue without AFLtables modifying their data.

rwarneke commented 4 years ago

The issue has been rectified by the owner of AFL Tables, who has edited the relevant page.